When you use an app architecture, separate each layer of your application, for example, you have a View layer that you working on your UI and no business logic of your app exist in this layer, so the code is concise and clear to read and maintain and debugging, you can write test better and some other benefits.Ģ- When you need a variable that you want to change later, you must use a var keyword, otherwise there is no need to declare a variable as a var.ģ- comments use for clearing some codes for other developers or yourself to understand these codes better, Avoiding unusable comments in your project.Ĥ- findViewById() method, is most costly, however if you use viewBinding android use this method behind the scene. Imagine you have a project, You are working on it, and this project gets larger and larger, if you want to debug your application or maintain it later, it's very difficult. When You coding You should each time formating your code with hotġ- Let's make it clear for you, it's about separation of concern! You should add Moshi library to your project for parsingĨ Code format could be improved (remove useless empty lines)
Please replace your hardcoded message string with adding strings toĦ.Manual json parsing (better use Gson/kotlinX.Serialization/Moshi) No usage of the Strings.xml (only hardcoded strings) If code is clear and understandable You mustn't comment on itĤ.using findViewById() method (better: enable DataBinding or ViewBinding)ĥ. You should add comments to explain logic if logic looks not clear
You should first add the comment for the public method inĬomments to write class describe like JavaDoc sets the text to the textview or return the number of the items in the list) You should understand the difference between mutable immutableģ. You should apply MVVM or MVP architecture for Your app.
0 kommentar(er)
